Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Poetry #192

Closed
zackproser opened this issue Aug 15, 2023 · 0 comments · Fixed by #193
Closed

Add support for Poetry #192

zackproser opened this issue Aug 15, 2023 · 0 comments · Fixed by #193

Comments

@zackproser
Copy link
Contributor

I think we should add support for managing the Pinecone Py thon client locally via Poetry,

For what it's worth, the Python LangChain library does this and it makes it easier to develop against LangChain locally while:

  • Seeing your edits to the library code reflected immediately
  • Tracking all your changes in git so they can be easily contributed back via your fork.
@zackproser zackproser mentioned this issue Aug 19, 2023
Merged
18 tasks
zackproser added a commit that referenced this issue Sep 29, 2023
@zackproser @austin-denoble
Support Poetry for local development. Add local development guide. (#193
c9f5a8d 
)

Closes #192

These changes add support for managing the Pinecone Python client via
[Poetry](https://python-poetry.org/), a virtualenv and dependency
manager.

These changes also add a new CONTRIBUTING guide which explains how to develop the Pinecone Python client locally even across multiple shells using Poetry.

The intent of this guide is to significantly ease local development of
Pinecone in scenario like Jupyter Notebooks and Python applications
where `pinecone` and supporting libraries such as `langchain` are often
imported after being `pip install`ed.

## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

---------

Co-authored-by: Austin DeNoble <austin.d@pinecone.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Poetry for local development. Add local development guide. zackproser/pinecone-python-client
1 participant
@zackproser