Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Poetry for local development. Add local development guide. #193

Merged
merged 31 commits into from
Sep 29, 2023
Merged

Support Poetry for local development. Add local development guide. #193

merged 31 commits into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. Poetry init and install dependencies

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7ca323d View commit details
    Browse the repository at this point in the history

  2. Fix package name and gRPC dependencies resolution

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    befb4c0 View commit details
    Browse the repository at this point in the history

  3. Add contributing + local development guide

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d768ae3 View commit details
    Browse the repository at this point in the history

  4. Contrib guide: Add info on what the guide will do

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    cf02edd View commit details
    Browse the repository at this point in the history

  5. Clarify virtualenv setup

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d811b86 View commit details
    Browse the repository at this point in the history

  6. Update and move Poetry CI actions. Author -> support@pinecone.io

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    cecf2de View commit details
    Browse the repository at this point in the history

  7. Update pyproject.toml to accept Python >=3.8,<4.0

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9833122 View commit details
    Browse the repository at this point in the history

  8. Delete requirements files. Deps will be managed by Poetry 

    -pyproject.toml will now be the source of truth for dependencies
    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    31cec9b View commit details
    Browse the repository at this point in the history

  9. Convert Makefile tests target to poetry

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f0dc25c View commit details
    Browse the repository at this point in the history

  10. Update develop, version, package targets to Poetry equivalents

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    511ceb0 View commit details
    Browse the repository at this point in the history

  11. Modify testing GitHub Actions workflow to use poetry

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9398ff9 View commit details
    Browse the repository at this point in the history

  12. Add missing period.

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d374a88 View commit details
    Browse the repository at this point in the history

  13. Remove obsolete comment from tox times

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fcae76d View commit details
    Browse the repository at this point in the history

  14. Attempt to fix GitHub action poetry smoke tests trigger

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    521412e View commit details
    Browse the repository at this point in the history

  15. Remove tox configuration in favor of Poetry (pyproject.toml)

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4d47edb View commit details
    Browse the repository at this point in the history

  16. Try to hook Poetry smoke tests into testing.yml workflow

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    526c88b View commit details
    Browse the repository at this point in the history

  17. Add poetry workflow call .yaml extension

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9a00ccc View commit details
    Browse the repository at this point in the history

  18. Simplify and condense poetry smoke tests into testing.yaml

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1f23173 View commit details
    Browse the repository at this point in the history

  19. Remove shell test

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3274345 View commit details
    Browse the repository at this point in the history

  20. Update release process to factor in Poetry 

    -Our pinecone/__version__ file has been the source of truth for
our release process
-Poetry uses pyproject.toml. For the time being, we need to update
both files. They should both always contain the same version
    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2acaede View commit details
    Browse the repository at this point in the history

  21. Separate gRPC dependencies via poetry install --extras "grpc"

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3d34d34 View commit details
    Browse the repository at this point in the history

  22. Update author in pyproject.toml. Delete setup.py and setup.cfg

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a3cc295 View commit details
    Browse the repository at this point in the history

  23. Update repo-level package name to match what setup.py had 

    -The repo level package is pinecone-client - e.g., pip install \
pinecone-client, and the pinecone subdirectory is the module
    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f9f7be9 View commit details
    Browse the repository at this point in the history

  24. Swap top-level package name back to pinecone

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    007541e View commit details
    Browse the repository at this point in the history

  25. Update pyproject.toml 

    Co-authored-by: Austin DeNoble <austin.d@pinecone.io>
    @zackproser @austin-denoble
    zackproser and austin-denoble committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f14e346 View commit details
    Browse the repository at this point in the history

  26. Update CONTRIBUTING.md 

    Co-authored-by: Austin DeNoble <austin.d@pinecone.io>
    @zackproser @austin-denoble
    zackproser and austin-denoble committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3c0e92a View commit details
    Browse the repository at this point in the history

  27. Remove unused tox dependency from pyproject.toml

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6f28544 View commit details
    Browse the repository at this point in the history

  28. Fix typo in pyproject.toml comment about dev deps

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7b17f7e View commit details
    Browse the repository at this point in the history

  29. Bump version to 2.3.0. Migrate setup.py changes from main

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e1f779d View commit details
    Browse the repository at this point in the history

  30. Harmonize versions with main

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0cad103 View commit details
    Browse the repository at this point in the history

  31. Update poetry.lock after removing tox dependency

    @zackproser
    zackproser committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    15fd509 View commit details
    Browse the repository at this point in the history