Check *.txt files for integration tests
#181
Conversation
This script will diff entire directories and filter for *.txt files. It will also round floating point numbers to account for the potential discrepency in floating point representation.
This was a place where it was (partially) missed during the crispresso2_info object refactoring.
|
Hey Cole, thanks, this is great. I had considered including all files for the test comparisons, but was hesitant because it may bloat the checkout or release size (I suppose we could tag this dir with export-ignore). Instead, I chose a few summary files which should show changes in the case of algorithmic differences. We probably don't need the pdfs or pngs, though right? What are your thoughts? |
|
Hey Kendell, I have been thinking about this, and I wonder if a good solution is to keep all of these solutions in a separate repo, and add then as a git submodule? That way the large folders won't be pulled by default, but those that want to run them can easily pull them in. As for the pdfs and pngs, I was looking into this SO question and was thinking about comparing the pngs and measuring the difference between the images. I thought I would implement this feature later, but I think we could remove the image files for now and add them later when (if) this gets implemented. |
When debugging the
find_indels_substitutionfunction, I noticed that these files didn't make it over from the other repo during the migration. In any case, these changes now diff across all of the*.txtfiles in the integration tests.I have also updated the CircleCI script to use this as well, there may be bugs in that update because I haven't been able to test it.
There is also a small bug fix included here for
CRISPRessoComparewhere the sample names weren't being properly loaded.