Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease Docker image size and fix PE naming and parameter behavior #404

Merged
merged 2 commits into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. Fix 'Prime-edited' key not found (#32)

    * Move 'Prime-edited' amplicon name check
    
    By moving this, it will check if there is an amplicon named
    'Prime-edited' (which is a reserved name) even if the
    `prime_editing_pegRNA_extension_seq` parameter is empty.
    
    * Only search for scaffold integration when pegRNA extension seq is provided
    
    * Remove spaces at the end of lines
    Colelyman committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    074155b View commit details
    Browse the repository at this point in the history
  2. Docker size (#49)

    * Bug Fix - 367 (#35)
    
    * - Fixed references to ref_names_for_pe
    
    * removed extra tabs
    
    * trying to match empty line, no tabs
    
    * - changed references to ref_names[0]
    
    * Mckay/pd warnings (#45)
    
    * refactor errors='ignore' to try except
    
    * refactored integer slice to iloc[]
    
    * moved to_numeric try except to function
    
    * Refactor to_numeric_ignore_errors to to_numeric_ignore_columns
    
    This change is slightly cleaner because it addresses the root issue that some
    columns are strings (and can therefore not be converted to numeric types). Now
    if an error does occur when converting the dfs to numeric types it won't be
    swallowed up.
    
    * Add documentation to to_numeric_ignore_columns
    
    ---------
    
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    ---------
    
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    * GitHub actions integration tests (#48)
    
    * GitHub actions clean (#40)
    
    * Create pytest.yml
    
    * Create pylint.yml
    
    * Create .pylintrc
    
    * Create test_env.yml
    
    * Full path
    
    * Remove conda install
    
    * Replace path
    
    * Pytest tests
    
    * pip -e
    
    * Create integration_tests.yml
    
    * Simplify name
    
    * CRISPRESSO2_DIR environment variable
    
    * Up one dir
    
    * ls workspace
    
    * Install CRISPResso and ydiff
    
    * Clone repo instead of checkout
    
    * submodule
    
    * ls
    
    * CRISPResso2_copy
    
    * ls
    
    * Update env
    
    * Simplify
    
    * Pull from githubactions branch
    
    * Pull githubactions repo
    
    * Checkout githubactions
    
    * Mckay/pd warnings (#45)
    
    * refactor errors='ignore' to try except
    
    * refactored integer slice to iloc[]
    
    * moved to_numeric try except to function
    
    * Refactor to_numeric_ignore_errors to to_numeric_ignore_columns
    
    This change is slightly cleaner because it addresses the root issue that some
    columns are strings (and can therefore not be converted to numeric types). Now
    if an error does occur when converting the dfs to numeric types it won't be
    swallowed up.
    
    * Add documentation to to_numeric_ignore_columns
    
    ---------
    
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    * Run tests individually
    
    * Pin plotly version
    
    * Run all tests even if one fails
    
    * Test on another branch
    
    * Switch branch with token
    
    * Update integration_tests.yml
    
    * Introduce pandas sorting in CRISPRessoCompare (#47)
    
    * New makefile commands
    
    * Fix interleaved fastq input in CRISPRessoPooled and suppress CRISPRessoWGS params (#42)
    
    * Extract out split_interleaved_fastq function to CRISPRessoShared
    
    * Implement splitting interleaved fastq files in CRISPRessoPooled
    
    * Suppress split_interleaved_input from CRISPRessoWGS parameters
    
    * Suppress other parameters in CRISPRessoWGS
    
    * Move where interleaved fastq files are split to be trimmed properly
    
    * Bug Fix - 367 (#35)
    
    * - Fixed references to ref_names_for_pe
    
    * removed extra tabs
    
    * trying to match empty line, no tabs
    
    * - changed references to ref_names[0]
    
    * Mckay/pd warnings (#45)
    
    * refactor errors='ignore' to try except
    
    * refactored integer slice to iloc[]
    
    * moved to_numeric try except to function
    
    * Refactor to_numeric_ignore_errors to to_numeric_ignore_columns
    
    This change is slightly cleaner because it addresses the root issue that some
    columns are strings (and can therefore not be converted to numeric types). Now
    if an error does occur when converting the dfs to numeric types it won't be
    swallowed up.
    
    * Add documentation to to_numeric_ignore_columns
    
    ---------
    
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    ---------
    
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    * On push no branches
    
    * On push no branches
    
    * All in one file
    
    * Fix yml errors
    
    * Rename jobs
    
    * Remove old workflow files
    
    * Remove paths
    
    * Run jobs in parallel
    
    ---------
    
    Co-authored-by: mbowcut2 <55161542+mbowcut2@users.noreply.github.com>
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    
    * 3.4->2.08
    
    * Put ttf-mscorefonts-installer back above apt-get clean
    
    * restore slash, replace fastp with trimmomatic and flash, add autoremove step
    
    ---------
    
    Co-authored-by: mbowcut2 <55161542+mbowcut2@users.noreply.github.com>
    Co-authored-by: Cole Lyman <cole@colelyman.com>
    3 people committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    47b3908 View commit details
    Browse the repository at this point in the history