Skip to content

Commit

Permalink
Merge pull request rails#4815 from kennyj/fix_4749
Browse files Browse the repository at this point in the history
Fix GH rails#4749. Remove branch options, because edge is not 3-2-stable.
  • Loading branch information
spastorino committed Feb 1, 2012
2 parents 1444ec6 + c8c8439 commit 21735d2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions railties/lib/rails/generators/app_base.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ def assets_gemfile_entry
# Gems used only for assets and not required # Gems used only for assets and not required
# in production environments by default. # in production environments by default.
group :assets do group :assets do
gem 'sass-rails', :git => 'git://github.com/rails/sass-rails.git', :branch => '3-2-stable' gem 'sass-rails', :git => 'git://github.com/rails/sass-rails.git'
gem 'coffee-rails', :git => 'git://github.com/rails/coffee-rails.git', :branch => '3-2-stable' gem 'coffee-rails', :git => 'git://github.com/rails/coffee-rails.git'
# See https://github.com/sstephenson/execjs#readme for more supported runtimes # See https://github.com/sstephenson/execjs#readme for more supported runtimes
#{javascript_runtime_gemfile_entry} #{javascript_runtime_gemfile_entry}
Expand Down
5 changes: 5 additions & 0 deletions railties/test/generators/shared_generator_tests.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ def test_edge_option
generator([destination_root], :edge => true).expects(:bundle_command).with('install').once generator([destination_root], :edge => true).expects(:bundle_command).with('install').once
quietly { generator.invoke_all } quietly { generator.invoke_all }
assert_file 'Gemfile', %r{^gem\s+["']rails["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/rails.git")}["']$} assert_file 'Gemfile', %r{^gem\s+["']rails["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/rails.git")}["']$}
assert_file 'Gemfile', %r{^gem\s+["']journey["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/journey.git")}["']$}
assert_file 'Gemfile', %r{^gem\s+["']arel["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/arel.git")}["']$}

assert_file 'Gemfile', %r{^\s+gem\s+["']sass-rails["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/sass-rails.git")}["']$}
assert_file 'Gemfile', %r{^\s+gem\s+["']coffee-rails["'],\s+:git\s+=>\s+["']#{Regexp.escape("git://github.com/rails/coffee-rails.git")}["']$}
end end


def test_skip_gemfile def test_skip_gemfile
Expand Down

0 comments on commit 21735d2

Please sign in to comment.