Skip to content

Commit

Permalink
Merge pull request rails#5278 from rafaelfranca/fix-build-3-2
Browse files Browse the repository at this point in the history
[3-2-stable] Fix build
  • Loading branch information
NZKoz committed Mar 5, 2012
2 parents 06a3a8a + 2a6b7e5 commit ebc5a19
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class Application < Rails::Application
# This will create an empty whitelist of attributes available for mass-assignment for all models
# in your app. As such, your models will need to explicitly whitelist or blacklist accessible
# parameters by using an attr_accessible or attr_protected declaration.
config.active_record.whitelist_attributes = true
<%= comment_if :skip_active_record %>config.active_record.whitelist_attributes = true

<% unless options.skip_sprockets? -%>
# Enable the asset pipeline
Expand Down
1 change: 1 addition & 0 deletions railties/test/application/loading_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def app
app_file "app/models/post.rb", <<-MODEL
class Post < ActiveRecord::Base
validates_acceptance_of :title, :accept => "omg"
attr_accessible :title
end
MODEL

Expand Down
6 changes: 6 additions & 0 deletions railties/test/generators/app_generator_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ def test_generator_if_skip_active_record_is_given
run_generator [destination_root, "--skip-active-record"]
assert_no_file "config/database.yml"
assert_file "config/application.rb", /#\s+require\s+["']active_record\/railtie["']/
assert_file "config/application.rb", /#\s+config\.active_record\.whitelist_attributes = true/
assert_file "test/test_helper.rb" do |helper_content|
assert_no_match(/fixtures :all/, helper_content)
end
Expand Down Expand Up @@ -375,6 +376,11 @@ def test_generated_environments_file_for_auto_explain
end
end

def test_active_record_whitelist_attributes_is_present_application_config
run_generator
assert_file "config/application.rb", /config\.active_record\.whitelist_attributes = true/
end

protected

def action(*args, &block)
Expand Down
2 changes: 1 addition & 1 deletion railties/test/isolation/abstract_unit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def use_frameworks(arr)
:activemodel,
:activerecord,
:activeresource] - arr
remove_from_config "config.active_record.identity_map = true" if to_remove.include? :activerecord
remove_from_config "config.active_record.whitelist_attributes = true" if to_remove.include? :activerecord
$:.reject! {|path| path =~ %r'/(#{to_remove.join('|')})/' }
end

Expand Down

0 comments on commit ebc5a19

Please sign in to comment.