profiling: remove some dependencies #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
changed the title
breezewish
reviewed
Apr 8, 2020
| tls bool | ||
| } | ||
|
|
||
| func (f *fetcher) Fetch(src string, duration, timeout time.Duration) (*profile.Profile, string, error) { |
There was a problem hiding this comment.
do we still need this function?
There was a problem hiding this comment.
Yes, we need to use it to get DOT output
pkg/apiserver/profiling/profile.go
Outdated
| default: | ||
| return "", fmt.Errorf("unsupported target %s", target) | ||
| } | ||
| } | ||
|
|
||
| func fetchFlameGraphSVG(ctx context.Context, httpClient *http.Client, target *utils.RequestTargetNode, fileNameWithoutExt string, profileDurationSecs uint, tls bool) (string, error) { |
There was a problem hiding this comment.
maybe we should call it something like fetchTiKVProfiling since this function will not work for all components
pkg/apiserver/profiling/profile.go
Outdated
| url := fmt.Sprintf("%s://%s:%d/debug/pprof/profile?seconds=%d", schema, target.IP, target.Port, profileDurationSecs) | ||
| req, err := http.NewRequest(http.MethodGet, url, nil) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
please make some more readable errors
pkg/apiserver/profiling/profile.go
Outdated
| case utils.NodeKindTiKV, utils.NodeKindTiDB: | ||
| url = "/debug/pprof/profile?seconds=" + secs | ||
| case utils.NodeKindTiKV: | ||
| return fetchFlameGraphSVG(ctx, httpClient, target, fileNameWithoutExt, profileDurationSecs, tls) |
There was a problem hiding this comment.
PD-Allow-follower-handle header will not be set for PD, is it ok?
There was a problem hiding this comment.
PD-Allow-follower-handle will be set for PD in getProfile function
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
Manually confirmed that it works 👏 |
breezewish
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.