This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Backup: register backupTS as safepoint to PD #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 48 48
Lines 4949 4949
=======================================
Hits 3483 3483
Misses 1003 1003
Partials 463 463 Continue to review full report at Codecov.
|
kennytm
reviewed
Apr 30, 2020
kennytm
approved these changes
May 6, 2020
3pointer
added a commit
to 3pointer/br
that referenced
this pull request
May 6, 2020
Co-authored-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
that referenced
this pull request
May 6, 2020
glkappe
added a commit
to glkappe/docs-cn
that referenced
this pull request
Nov 12, 2020
Br adaptive GC description pingcap/br#257
9 tasks
TomShawn
added a commit
to pingcap/docs-cn
that referenced
this pull request
Nov 19, 2020
* Br adaptive GC description Br adaptive GC description pingcap/br#257 * Update backup-and-restore-use-cases.md 增加了修复版本链接, 请帮忙检查 * update 增加了修复版本链接, 请帮忙检查 * refine language * Update br/backup-and-restore-use-cases.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR can register backupTS as safePoint to PD, so the SafePoint won't move forward during backup. Avoid manually set GC safePoint.
What is changed and how it works?
Use
pdClient.UpdateServiceSafePointinterface to lock down safePoint with TTL(60 secs)Check List
Tests
Related changes
need cherry-pick to release-4.0