This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Remove meta package and make br easy to integrate to other project #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
force-pushed
the
remove-meta
branch
from
d01be64
to
82d0991
Compare
Signed-off-by: Neil Shen <overvenus@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 25 25
Lines 3258 3258
=======================================
Hits 2326 2326
Misses 659 659
Partials 273 273Continue to review full report at Codecov.
|
kennytm
reviewed
Dec 7, 2019
cmd/cmd.go
Outdated
Comment on lines
155
to
158
| storage, err = tikv.Driver{}.Open( | ||
| // Disable GC because TiDB enables GC already. | ||
| fmt.Sprintf("tikv://%s?disableGC=true", pdAddress)) | ||
| defaultMgr, err = conn.NewMgr(defaultContext, pdAddress, storage.(tikv.Storage)) |
There was a problem hiding this comment.
Handle the err in line 155. Currently the err in line 158 overwrites the err in line 155.
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
3pointer
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed and split meta package into other packages.