Support helm-less install #466

cwen0 · 2020-05-06T16:25:32Z

What problem does this PR solve?

What is changed and how does it work?

remove helm dependency from install.sh
support helm-less install

# install chaos mesh
curl -sSL https://raw.githubusercontent.com/cwen0/chaos-mesh/add_dry_run/install.sh | sh 

# install chaos-mesh with kubectl 
curl -sSL https://raw.githubusercontent.com/cwen0/chaos-mesh/add_dry_run/install.sh | sh -s -- --dry-run  | kubectl apply -f -  

# install kind cluster and chaos mesh
curl -sSL https://raw.githubusercontent.com/cwen0/chaos-mesh/add_dry_run/install.sh | sh -s -- -l kind

Check List

Tests

Manual test (add detailed scripts or steps below)

Signed-off-by: cwen0 <cwenyin0@gmail.com>

yeya24 · 2020-05-06T16:35:40Z

install.sh

 OPTIONS:
    -v, --version            Version of chaos-mesh, default value: latest
    -l, --local [kind]       Choose a way to run a local kubernetes cluster, supported value: kind,
                             If this value is not set and the Kubernetes is not installed, this script will exit with 1.
    -n, --name               Name of Kubernetes cluster, default value: kind
+    -c  --crd                The URL of the crd files, default value: https://raw.githubusercontent.com/pingcap/chaos-mesh/master/manifests/crd.yaml
+    -r  --runc               Runtime specifies which container runtime to use. Currently we only supports docker and containerd. default value: docker


What about --runtime, runc is not that appropriate here

yeya24 · 2020-05-06T16:36:38Z

install.sh

 OPTIONS:
    -v, --version            Version of chaos-mesh, default value: latest
    -l, --local [kind]       Choose a way to run a local kubernetes cluster, supported value: kind,
                             If this value is not set and the Kubernetes is not installed, this script will exit with 1.
    -n, --name               Name of Kubernetes cluster, default value: kind
+    -c  --crd                The URL of the crd files, default value: https://raw.githubusercontent.com/pingcap/chaos-mesh/master/manifests/crd.yaml


What is the use case that we need to expose this flag? Does it need to be configurable?

Using a relative path is enough here?

If we use a relative path, we must use exec this script in specific directory.

Yes, but we have to. It is not appropriate to use /master in such script. If we want to run this script in the release branch, then what is the value of crd? Do we have to update to https://raw.githubusercontent.com/pingcap/chaos-mesh/<tag>/manifests/crd.yaml every time?

When we need to release, we also need to change the image to install, so I think we also need to update this, or we add a flag to define the version of chaos-mesh.

I still think it is better to use relative path. If using master, then how to test each PR in CI? We have to update the path to each PR's CRD?

this pr has no relation to CI. Why need to use this pr in CI?

Sorry I mean not CI, just in each branch. If we are in different branches and run this script, then we have to still update the crd url every time? I don't think it is reasonable

Maybe we can support to set a relative path and use the URL as a default value.

yeya24 · 2020-05-06T16:43:17Z

install.sh

+    CA_BUNDLE=$(openssl base64 -A -in ${tmpdir}/ca.crt)
+
+    cat <<EOF
+---


Is it possible to not copy all these yaml templates in this script? It would be a pain that we have to update both this script and the helm templates when there is a change.

I just want to provide a more convenient installation method and do not rely on helm, Do you have any other good solutions?

Maybe we can add a hack script to help use us update this.

Maybe a hack script can be executed after make yaml and checked by CI

yeya24 · 2020-05-06T16:43:51Z

install.sh

+            - --runtime
+            - ${runc}
+            - --http-port
+            - !!str 31766


!!str is not needed

If we delete !!str, the program will report an error.

Error from server (BadRequest): error when creating "STDIN": DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Command: []string: ReadString: expects " or n, but found 3, error found in #10 byte of ...|tp-port",31766,"--gr|..., bigger context ...|s-daemon","--runtime","containerd","--http-port",31766,"--grpc-port",31767],"image":"pingcap/chaos-d|...

yeya24 · 2020-05-06T16:43:57Z

install.sh

+            - --http-port
+            - !!str 31766
+            - --grpc-port
+            - !!str 31767


!!str is not needed

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 · 2020-05-12T08:31:21Z

@Gallardot @yeya24 @fewdan PTAL again! Thanks!

fewdan

LGTM

Gallardot · 2020-05-12T16:11:32Z

who and when need to execute the ‘make update-install-script’ ?

yeya24

Great work! LGTM

cwen0 · 2020-05-13T02:38:29Z

who and when need to execute the ‘make update-install-script’ ?

when we update helm charts, we need run make update-install-script to update install.sh. helm --dry-run requires a Kubernetes environment, so we can't add it at CI at present.

cwen0 · 2020-05-13T04:15:28Z

/merge

sre-bot · 2020-05-13T04:15:31Z

Your auto merge job has been accepted, waiting for:

478

sre-bot · 2020-05-13T04:19:02Z

/run-all-tests

sre-bot · 2020-05-13T04:21:06Z

@cwen0 merge failed.

cwen0 added 5 commits May 6, 2020 23:01

remove helm from install.sh

102a988

Signed-off-by: cwen0 <cwenyin0@gmail.com>

fix runc

58b076c

Signed-off-by: cwen0 <cwenyin0@gmail.com>

create namespace

9164a21

Signed-off-by: cwen0 <cwenyin0@gmail.com>

update container runtime

ef5ccac

Signed-off-by: cwen0 <cwenyin0@gmail.com>

fix a little bug

9f74ff0

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 added component/scripts status/PTAL labels May 6, 2020

yeya24 reviewed May 6, 2020

View reviewed changes

address comments

414cff8

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 added 3 commits May 11, 2020 16:48

Merge remote-tracking branch 'upstream/master' into add_dry_run

ee4097d

add update_install_script.sh

01a6eda

Signed-off-by: cwen0 <cwenyin0@gmail.com>

Merge remote-tracking branch 'upstream/master' into add_dry_run

01da2c0

fewdan approved these changes May 12, 2020

View reviewed changes

yeya24 approved these changes May 12, 2020

View reviewed changes

sre-bot added the status/can-merge label May 13, 2020

Merge branch 'master' into add_dry_run

8ba5a4e

cwen0 merged commit 4198785 into chaos-mesh:master May 13, 2020

cwen0 deleted the add_dry_run branch May 13, 2020 04:21

cwen0 mentioned this pull request May 13, 2020

helm-less install #431

Closed

sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021

Support helm-less install (chaos-mesh#466)

e8f08c9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support helm-less install #466

Support helm-less install #466

cwen0 commented May 6, 2020 •

edited

Loading

yeya24 May 6, 2020

yeya24 May 6, 2020

yeya24 May 6, 2020

cwen0 May 7, 2020

yeya24 May 7, 2020

cwen0 May 7, 2020

yeya24 May 7, 2020

cwen0 May 7, 2020

yeya24 May 7, 2020

cwen0 May 12, 2020 •

edited

Loading

cwen0 May 12, 2020

yeya24 May 6, 2020

Gallardot May 7, 2020

cwen0 May 7, 2020

cwen0 May 7, 2020

Gallardot May 7, 2020

cwen0 May 12, 2020

yeya24 May 6, 2020

cwen0 May 7, 2020

yeya24 May 6, 2020

cwen0 commented May 12, 2020

fewdan left a comment

Gallardot commented May 12, 2020

yeya24 left a comment

cwen0 commented May 13, 2020

cwen0 commented May 13, 2020

sre-bot commented May 13, 2020

sre-bot commented May 13, 2020

sre-bot commented May 13, 2020

Support helm-less install #466

Support helm-less install #466

Conversation

cwen0 commented May 6, 2020 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwen0 May 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwen0 commented May 12, 2020

fewdan left a comment

Choose a reason for hiding this comment

Gallardot commented May 12, 2020

yeya24 left a comment

Choose a reason for hiding this comment

cwen0 commented May 13, 2020

cwen0 commented May 13, 2020

sre-bot commented May 13, 2020

sre-bot commented May 13, 2020

sre-bot commented May 13, 2020

cwen0 commented May 6, 2020 •

edited

Loading

cwen0 May 12, 2020 •

edited

Loading