Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI implementation of creating a new experiment #481

Merged
merged 14 commits into from
May 13, 2020
Merged

New UI implementation of creating a new experiment #481

merged 14 commits into from
May 13, 2020

Conversation

xuechunL
Copy link
Contributor

@xuechunL xuechunL commented May 9, 2020

What problem does this PR solve?

  • add GitHub link of chaos mesh repo
  • update some UI feats

What is changed and how does it work?

  • refine the HTML page title with '| Chaos Mesh Dashboard' suffix
  • change the UI of creating a new experiment
  • refine the implementation of flexbox with Material Ui built-in Box component (https://material-ui.com/system/flexbox/)

# Conflicts:
#	ui/.prettierignore
#	ui/.prettierrc
#	ui/README.md
#	ui/package.json
#	ui/public/index.html
#	ui/src/App.test.tsx
#	ui/src/App.tsx
#	ui/src/components/Container/index.tsx
#	ui/src/components/PageBar/index.tsx
#	ui/src/components/ToolBar/index.tsx
#	ui/src/index.tsx
#	ui/src/pages/Archives/index.tsx
#	ui/src/pages/Events/index.tsx
#	ui/src/pages/Experiments/Detail.tsx
#	ui/src/pages/Experiments/New.tsx
#	ui/src/pages/Experiments/index.tsx
#	ui/src/pages/Overview/index.tsx
#	ui/src/routes.tsx
#	ui/src/setupTests.ts
#	ui/src/theme.ts
#	ui/tsconfig.json
#	ui/yarn.lock
@xuechunL xuechunL requested a review from g1eny0ung May 9, 2020 10:38
@xuechunL xuechunL requested a review from cwen0 May 9, 2020 10:41
@xuechunL
Copy link
Contributor Author

xuechunL commented May 9, 2020

screen shots:
overview
experiments
new-experiment-modal
finish-step
experiment-detail
events
archives

Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove PWA related files.

@xuechunL
Copy link
Contributor Author

xuechunL commented May 11, 2020

Need to remove PWA related files.

OK,i'll do this later, these are the stale files from the PR#439.

@g1eny0ung
Copy link
Member

Ok, no problem.

@xuechunL xuechunL requested a review from g1eny0ung May 12, 2020 03:21
ui/src/components/NavBar/index.tsx Outdated Show resolved Hide resolved
ui/src/components/ToolBar/index.tsx Show resolved Hide resolved
ui/src/pages/Experiments/index.tsx Outdated Show resolved Hide resolved
@xuechunL xuechunL requested a review from g1eny0ung May 12, 2020 07:53
@codecov-io
Copy link

Codecov Report

Merging #481 into master will increase coverage by 0.30%.
The diff coverage is 53.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   58.57%   58.88%   +0.30%     
==========================================
  Files          60       68       +8     
  Lines        3626     4385     +759     
==========================================
+ Hits         2124     2582     +458     
- Misses       1333     1611     +278     
- Partials      169      192      +23     
Impacted Files Coverage Δ
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/iochaos_types.go 31.11% <0.00%> (-1.45%) ⬇️
api/v1alpha1/kernelchaos_types.go 4.44% <0.00%> (-0.21%) ⬇️
api/v1alpha1/networkchaos_types.go 18.65% <0.00%> (-0.29%) ⬇️
api/v1alpha1/podchaos_types.go 31.11% <0.00%> (-1.45%) ⬇️
controllers/stresschaos_controller.go 0.00% <0.00%> (ø)
controllers/timechaos_controller.go 0.00% <0.00%> (ø)
controllers/twophase/types.go 55.78% <0.00%> (-7.31%) ⬇️
pkg/chaosdaemon/netem_linux.go 26.66% <0.00%> (-17.78%) ⬇️
pkg/chaosdaemon/netlink_linux.go 0.00% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9947894...7cd3b7a. Read the comment docs.

Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great jobs. I have no problems. @cwen0

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 13, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

@xuechunL merge failed.

@cwen0 cwen0 merged commit 2dbab6c into chaos-mesh:master May 13, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants