-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI implementation of creating a new experiment #481
Conversation
# Conflicts: # ui/.prettierignore # ui/.prettierrc # ui/README.md # ui/package.json # ui/public/index.html # ui/src/App.test.tsx # ui/src/App.tsx # ui/src/components/Container/index.tsx # ui/src/components/PageBar/index.tsx # ui/src/components/ToolBar/index.tsx # ui/src/index.tsx # ui/src/pages/Archives/index.tsx # ui/src/pages/Events/index.tsx # ui/src/pages/Experiments/Detail.tsx # ui/src/pages/Experiments/New.tsx # ui/src/pages/Experiments/index.tsx # ui/src/pages/Overview/index.tsx # ui/src/routes.tsx # ui/src/setupTests.ts # ui/src/theme.ts # ui/tsconfig.json # ui/yarn.lock
…ment a dumb stepper for creating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove PWA related files.
OK,i'll do this later, these are the stale files from the PR#439. |
Ok, no problem. |
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 58.57% 58.88% +0.30%
==========================================
Files 60 68 +8
Lines 3626 4385 +759
==========================================
+ Hits 2124 2582 +458
- Misses 1333 1611 +278
- Partials 169 192 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great jobs. I have no problems. @cwen0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@xuechunL merge failed. |
What problem does this PR solve?
What is changed and how does it work?