Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams/docs: a vote for Icemap as the committer #780

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

qiancai
Copy link
Contributor

@qiancai qiancai commented Feb 6, 2024

As stated in the title.

@qiancai qiancai requested a review from a team as a code owner February 6, 2024 08:46
@ti-chi-bot ti-chi-bot bot requested a review from lilin90 February 6, 2024 08:46
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

@Oreoxmt: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 09:34:25.25104141 +0000 UTC m=+262990.817811286: ☑️ agreed by lilin90.
  • 2024-02-28 06:29:11.816719467 +0000 UTC m=+1029840.564342581: ✖️🔁 reset by qiancai.

Copy link

ti-chi-bot bot commented Feb 28, 2024

New changes are detected. LGTM label has been removed.

@qiancai qiancai added the lgtm label Feb 28, 2024
@wuhuizuo
Copy link
Contributor

/lgtm

Copy link

ti-chi-bot bot commented Feb 28, 2024

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/assign @zhangyangyu

Copy link

ti-chi-bot bot commented Feb 28, 2024

@wuhuizuo: GitHub didn't allow me to assign the following users: zhangyangyu.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zhangyangyu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90, Oreoxmt, wuhuizuo, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 28, 2024
@wuhuizuo wuhuizuo merged commit 00d914c into pingcap:master Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants