Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nominate yibin87 as tidb reviewer #786

Merged
merged 2 commits into from
May 6, 2024
Merged

nominate yibin87 as tidb reviewer #786

merged 2 commits into from
May 6, 2024

Conversation

XuHuaiyu
Copy link
Contributor

As the title says

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 28, 2024
@zanmato1984
Copy link
Contributor

+1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@XuHuaiyu XuHuaiyu requested a review from a team as a code owner May 6, 2024 05:25
@ti-chi-bot ti-chi-bot bot removed the lgtm label May 6, 2024
Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, winoros, zhangyangyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 11:26:43.027602899 +0000 UTC m=+183756.784738472: ☑️ agreed by winoros.
  • 2024-05-06 05:25:12.817061301 +0000 UTC m=+853266.574196873: ✖️🔁 reset by zanmato1984.
  • 2024-05-06 05:25:50.433062505 +0000 UTC m=+853304.190198078: ☑️ agreed by zhangyangyu.

@zhangyangyu
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot bot merged commit eb53030 into master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants