This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
loader: generate db-schema-create.sql file if not exists #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
================================================
- Coverage 53.2932% 53.2504% -0.0429%
================================================
Files 121 121
Lines 13816 13829 +13
================================================
+ Hits 7363 7364 +1
- Misses 5709 5717 +8
- Partials 744 748 +4 |
kennytm
reviewed
Jun 25, 2019
loader/util.go
Outdated
| } | ||
| defer file.Close() | ||
|
|
||
| file.WriteString(fmt.Sprintf("CREATE DATABASE `%s`;\n", schema)) |
There was a problem hiding this comment.
Use fmt.Fprintf?
What if schema contains a `?
There was a problem hiding this comment.
also need to check error returned from fmt.Fprintf or file.WriteString
There was a problem hiding this comment.
addressed in 25659ee
There was a problem hiding this comment.
do you have any suggestion when schema contains `? @kennytm
There was a problem hiding this comment.
There should be a function somewhere which replaces ` with ``
There was a problem hiding this comment.
done in d87c959
PTAL again
Co-Authored-By: kennytm <kennytm@gmail.com>
…nto xiang/refine_loader
WangXiangUSTC
added
status/LGT1
amyangfei
added
status/LGT2
WangXiangUSTC
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
mydumper will not dump schema create sql sometimes, and then loader will return error.
fix issue https://internal.pingcap.net/jira/browse/TOOL-1316
What is changed and how it works?
create schema create sql file if not find
Check List
Tests
Related changes