Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: upgrade build go version, add more build direction #71

Merged
merged 5 commits into from
Mar 12, 2019
Merged

*: upgrade build go version, add more build direction #71

merged 5 commits into from
Mar 12, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Mar 9, 2019 •
edited
Loading

What problem does this PR solve?

Support DM to build with higher version of Go. Go pre-1.11.4 version may have incorrect checksum in modules. ref: golang/go#29278

What is changed and how it works?

  • update some checksum in go.sum
  • update go vet to support go 1.12
  • update some build direction

Check List

Tests

  • Unit test
  • Integration test

@amyangfei amyangfei added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/enhancement Performance improvement or refactoring labels Mar 9, 2019
@amyangfei
Copy link
Contributor Author

we need to upgrade go version in JenkinsCI >= 1.11.4 to pass CI, what do you think of it? @GregoryIan @csuzhangxc

@kennytm
Copy link
Contributor

kennytm commented Mar 9, 2019

Let's just upgrade pingcap/SRE's dm_ghpr_test.groovy to use Go 1.12?

@csuzhangxc
Copy link
Member

TiDB already upgraded to Go 1.12 (pingcap/tidb#9299).
for DM, how about >= 1.12?

@zhouqiang-cl
Copy link
Contributor

Hi, today I and guanzhongyang just upgrade tidb to go1.12 in base image, If need, I thank it is time to upgrade to 1.12 for dm/lightning/binlog

@amyangfei
Copy link
Contributor Author

amyangfei commented Mar 9, 2019 •
edited
Loading

yeah I prefer Go 1.12.
And we should upgrade the following Go version in JenkinsCI

  • DM pr CI
  • DM master CI
  • BM master build

@gregwebs
Copy link

1.12 has incorrect checksums. It would help contributors if pingcap moved everything to a version with correct checksumes.

@amyangfei amyangfei mentioned this pull request Mar 11, 2019
Closed
@amyangfei
Copy link
Contributor Author

1.12 has incorrect checksums. It would help contributors if pingcap moved everything to a version with correct checksumes.

hi @gregwebs Did you mean go 1.11.2 has incorrect checksums?

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei mentioned this pull request Mar 11, 2019
Closed
@amyangfei amyangfei added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Mar 11, 2019
@amyangfei
Copy link
Contributor Author

go vet failed in JenkinsCI because of some unknown reason (not related to DM itself), ref: #72
We comment the go vet test and make CI pass, I will add them back after JenkinsCI fix the issue.
PTAL @GregoryIan @csuzhangxc

@gregwebs
Copy link

hi @gregwebs Did you mean go 1.11.2 has incorrect checksums?

Yes!

@gregwebs
Copy link

Sorry, I read this wrong and you are moving to 1.12 which has correct checksums, sounds good.

@amyangfei
Copy link
Contributor Author

go vet failed in JenkinsCI because of some unknown reason (not related to DM itself), ref: #72
We comment the go vet test and make CI pass, I will add them back after JenkinsCI fix the issue.

go module cache has been added in container image in JenkinsCI, so we add go vet test back

csuzhangxc
csuzhangxc reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 12, 2019
@IANTHEREAL
Copy link
Collaborator

LGTM

@amyangfei amyangfei added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Mar 12, 2019
@amyangfei amyangfei removed the status/LGT1 One reviewer already commented LGTM label Mar 12, 2019
@amyangfei amyangfei merged commit 7202e9b into pingcap:master Mar 12, 2019
@amyangfei amyangfei deleted the build-tuning branch March 12, 2019 02:45
@amyangfei amyangfei mentioned this pull request Mar 12, 2019
Closed
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@amyangfei
*: upgrade build go version, add more build direction (pingcap#71)
2a4a08f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amyangfei @kennytm @csuzhangxc @zhouqiang-cl @gregwebs @IANTHEREAL