Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

ctl: support using task-file when need task-name #854

Merged
merged 4 commits into from
Aug 4, 2020
Merged

ctl: support using task-file when need task-name #854

merged 4 commits into from
Aug 4, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

part of #826

What is changed and how it works?

support using task-file when need task-name

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature labels Aug 3, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #854 into master will decrease coverage by 1.0956%.
The diff coverage is 40.7647%.

@@               Coverage Diff                @@
##             master       #854        +/-   ##
================================================
- Coverage   57.0981%   56.0025%   -1.0957%     
================================================
  Files           205        214         +9     
  Lines         21104      22324      +1220     
================================================
+ Hits          12050      12502       +452     
- Misses         7890       8584       +694     
- Partials       1164       1238        +74

@csuzhangxc csuzhangxc added this to In progress in Usability Improvement via automation Aug 4, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Aug 4, 2020
csuzhangxc
csuzhangxc reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/ctl/common/util.go Show resolved Hide resolved
dm/ctl/master/operate_schema.go Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 4, 2020
Usability Improvement automation moved this from In progress to Reviewer approved Aug 4, 2020
@GMHDBJD GMHDBJD merged commit 3ab722c into pingcap:master Aug 4, 2020
Usability Improvement automation moved this from Reviewer approved to Done Aug 4, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 4, 2020
@GMHDBJD GMHDBJD mentioned this pull request Aug 6, 2020
Open
4 tasks
@lance6716 lance6716 deleted the task-file branch August 13, 2020 02:52
lance6716 added a commit to lance6716/dm that referenced this pull request Aug 13, 2020
@lance6716
ctl: support using task-file when need task-name (pingcap#854)
adc645d
This was referenced Aug 13, 2020
Merged
Merged
lance6716 added a commit that referenced this pull request Aug 14, 2020
@lance6716
ctl: support using task-file when need task-name (#854) (#892)
b88e58b
@csuzhangxc
Copy link
Member

docs PR pingcap/docs-dm#220

@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Aug 14, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
6 tasks
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Aug 17, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
Usability Improvement
  
Done
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD