Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support using task-file when need task-name #220

Merged
merged 9 commits into from
Aug 17, 2020
Merged

support using task-file when need task-name #220

merged 9 commits into from
Aug 17, 2020

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 13, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

support using task-file when need task-name

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v2.0 This PR/issue applies to TiDB DM v2.0. labels Aug 13, 2020
@ireneontheway ireneontheway self-assigned this Aug 13, 2020
csuzhangxc
csuzhangxc reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

zh/resume-task.md Outdated Show resolved Hide resolved
@lance6716 @csuzhangxc
Update zh/resume-task.md
51a7f02 
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
csuzhangxc
csuzhangxc reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
@ireneontheway ireneontheway removed the request for review from yikeke August 13, 2020 07:15
ireneontheway
ireneontheway approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@ireneontheway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@lance6716 lance6716 mentioned this pull request Aug 14, 2020
Merged
@csuzhangxc csuzhangxc mentioned this pull request Aug 14, 2020
Merged
@ti-srebot
Copy link
Contributor

@csuzhangxc, @ireneontheway, @GMHDBJD, PTAL.

@csuzhangxc
Copy link
Member

@TomShawn two LGTM now, PTAL

@TomShawn TomShawn added the size/small Changes of a small size. label Aug 17, 2020
@TomShawn TomShawn merged commit 98ca228 into pingcap:master Aug 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Aug 17, 2020
@lance6716 @ti-srebot
cherry pick pingcap#220 to release-1.0
ab048ad 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
6 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #239

@lance6716 lance6716 deleted the patch-3 branch August 17, 2020 08:23
@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Aug 17, 2020
ti-srebot added a commit that referenced this pull request Aug 17, 2020
@ti-srebot
support using task-file when need task-name (#220) (#239)
0a5c01c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@yikeke yikeke added the v1.0 This PR/issue applies to TiDB DM v1.0. label Aug 18, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 19, 2020
Merged
6 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated. label Aug 19, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 19, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 19, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@ireneontheway ireneontheway ireneontheway approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees

@Joyinqin Joyinqin

Labels
needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated. v1.0 This PR/issue applies to TiDB DM v1.0. v2.0 This PR/issue applies to TiDB DM v2.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lance6716 @ti-srebot @csuzhangxc @Joyinqin @ireneontheway @yikeke @TomShawn