Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observability for ALTER TABLE ... COMPACT #10470

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Add observability for ALTER TABLE ... COMPACT #10470

merged 3 commits into from
Jul 18, 2022

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jul 12, 2022 •
edited by shichun-0415

Signed-off-by: Wish breezewish@outlook.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add some notes to observe the ALTER TABLE ... COMPACT command.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions) Merge only after v6.1.1 is released
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@breezewish
Add observability for ALTER TABLE ... COMPACT
1254d8c 
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@shichun-0415 shichun-0415 added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR’s assignee is translating this PR. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 12, 2022
@shichun-0415
Copy link
Contributor

/verify

@shichun-0415 shichun-0415 self-assigned this Jul 12, 2022
breezewish
breezewish commented Jul 13, 2022
View reviewed changes
Copy link
Member Author

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flowbehappy PTAL, thanks!

@breezewish
Add examples for partition table
a28929a 
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
JaySon-Huang
JaySon-Huang approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shichun-0415
shichun-0415 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 18, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 391f5a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@ti-chi-bot ti-chi-bot merged commit 3da41b7 into master Jul 18, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10558.

@shichun-0415 shichun-0415 deleted the wenxuan/alter-table-compact-3 branch July 18, 2022 09:25
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Add observability for ALTER TABLE ... COMPACT (#10470) (#10558)
0b59bbb
@shichun-0415 shichun-0415 mentioned this pull request Dec 22, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 22, 2022
This was referenced Dec 23, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees

@shichun-0415 shichun-0415

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@breezewish @ti-chi-bot @shichun-0415 @JaySon-Huang @Lloyd-Pottiger