Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observability for ALTER TABLE ... COMPACT #11684

Merged
merged 3 commits into from Dec 23, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shichun-0415 shichun-0415 requested review from breezewish and removed request for ran-huang December 22, 2022 10:53
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. missing-translation-status This PR does not have translation status info. labels Dec 22, 2022
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Only some minor suggestions.

sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2022
Co-authored-by: Wenxuan <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2022
@Oreoxmt Oreoxmt self-requested a review December 23, 2022 02:59
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table-compact.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2022
Co-authored-by: Aolin <aolinz@outlook.com>
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cb7021d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2022
@ti-chi-bot ti-chi-bot merged commit 1ac90cf into pingcap:master Dec 23, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #11713.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #11714.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #11715.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #11716.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants