Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faq: refine the writing style of 3 faqs #11430

Merged
merged 17 commits into from
Sep 30, 2022
Merged

faq: refine the writing style of 3 faqs #11430

merged 17 commits into from
Sep 30, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

faq: refine the writing style of 3 faqs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2022
TomShawn
TomShawn commented Sep 27, 2022
View reviewed changes
faq/high-reliability-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 27, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 27, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 27, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added type/enhancement This issue/PR improves documentation usability or supplements document content. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Sep 27, 2022
TomShawn
TomShawn commented Sep 27, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 28, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Sep 28, 2022
@TomShawn TomShawn self-assigned this Sep 28, 2022
lilin90
lilin90 reviewed Sep 29, 2022
View reviewed changes
faq/high-reliability-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated
TiDB 在执行 SQL 语句时，会使用当时的 `schema` 来处理该 SQL 语句，而且 TiDB 支持在线异步变更 DDL。那么，在执行 DML 的时候可能有 DDL 语句也在执行，而你需要确保每个 SQL 语句在同一个 `schema` 上执行。所以当执行 DML 时，遇到正在执行中的 DDL 操作就可能会报 `Information schema is changed` 的错误。为了避免太多的 DML 语句报错，已做了一些优化。

现在会报此错的可能原因如下（只有第一个报错原因与表有关）：
当执行 DML 时，如果超过一个 DDL lease 时间（默认 45s）TiDB 没能加载到最新的 schema 就可能会报 `Information schema is out of date` 的错误。遇到此错的可能原因如下：
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根据 TiDB 集群问题导图 里的 3.1.3 和 3.1.4，原因可能有多种。当前这句话的描述看起来更像 information schema is out of date 的原因？🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, changes reverted.

TomShawn and others added 3 commits September 29, 2022 11:35
@TomShawn @lilin90
Update faq/sql-faq.md
2561887 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn @lilin90
Apply suggestions from code review
f963b79 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn
Update sql-faq.md
da2e2a9
TomShawn
TomShawn commented Sep 29, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 29, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
@TomShawn TomShawn mentioned this pull request Sep 29, 2022
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 29, 2022
lilin90
lilin90 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

faq/sql-faq.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2022
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 30, 2022
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5abcc64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit 079cefc into pingcap:master Sep 30, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11479.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 30, 2022
@TomShawn @ti-chi-bot
faq: refine the writing style of 3 faqs (pingcap#11430)
5be1170
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11480.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 30, 2022
@TomShawn @ti-chi-bot
faq: refine the writing style of 3 faqs (pingcap#11430)
b891e88
@TomShawn TomShawn deleted the refine-sql-faq branch September 30, 2022 06:39
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
faq: refine the writing style of 3 faqs (#11430) (#11479)
7457222
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
faq: refine the writing style of 3 faqs (#11430) (#11480)
b1269ff
This was referenced Oct 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@TomShawn TomShawn

Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomShawn @ti-chi-bot @lilin90