Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faq: refine the writing style of 3 faqs #10586

Merged
merged 7 commits into from Oct 8, 2022
Merged

faq: refine the writing style of 3 faqs #10586

merged 7 commits into from Oct 8, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

faq: refine the writing style of 3 faqs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
@TomShawn TomShawn requested review from lilin90 and removed request for shichun-0415 September 29, 2022 09:46
@TomShawn TomShawn added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Sep 29, 2022
TomShawn
TomShawn commented Sep 29, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 29, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Sep 30, 2022
View reviewed changes
tidb-troubleshooting-map.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Oct 7, 2022
View reviewed changes
faq/high-reliability-faq.md Outdated Show resolved Hide resolved
faq/high-reliability-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
TomShawn and others added 3 commits October 8, 2022 09:38
@TomShawn @lilin90
Apply suggestions from code review
174a520 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn @lilin90
Update faq/high-reliability-faq.md
0625599 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn
Merge branch 'master' into pr/10586
ebadc63
lilin90
lilin90 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Oct 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebadc63

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2022
@ti-chi-bot ti-chi-bot merged commit 99ff6ad into pingcap:master Oct 8, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 8, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10636.

@TomShawn TomShawn deleted the refine-sql-2h-faq branch October 8, 2022 02:08
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 8, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10637.

ti-chi-bot added a commit that referenced this pull request Oct 8, 2022
@ti-chi-bot
faq: refine the writing style of 3 faqs (#10586) (#10636)
79b99f5
ti-chi-bot added a commit that referenced this pull request Oct 8, 2022
@ti-chi-bot
faq: refine the writing style of 3 faqs (#10586) (#10637)
39404ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomShawn @ti-chi-bot @lilin90