Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions of new panels and update the plan cache doc #11799

Merged
merged 7 commits into from
Nov 7, 2022
Merged

Add descriptions of new panels and update the plan cache doc #11799

merged 7 commits into from
Nov 7, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Oct 26, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Add descriptions about Plan Cache Memory Usage and Plan Cache Plan Num
  • Update plan cache doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2022
@Oreoxmt Oreoxmt added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 26, 2022
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Oct 26, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 26, 2022
@Oreoxmt Oreoxmt self-requested a review October 26, 2022 08:49
@Oreoxmt Oreoxmt added the area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. label Oct 26, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 26, 2022

/cc @qw4990 PTAL

@ti-chi-bot
Copy link
Member

@fzzf678: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qw4990 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oreoxmt
Oreoxmt reviewed Oct 26, 2022
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review October 26, 2022 09:03
@fzzf678 @Oreoxmt
Apply suggestions from code review
159c112 
Co-authored-by: Aolin <aolinz@outlook.com>
@fzzf678 fzzf678 mentioned this pull request Oct 27, 2022
Closed
25 tasks
qw4990
qw4990 reviewed Oct 27, 2022
View reviewed changes
sql-prepared-plan-cache.md Outdated
比如目前 TiDB 实例的 `SESSION` 并发数是 50，平均每个 `SESSION` 大致缓存 100 个计划，则总内存开销为 `50 * 100 * 100KiB` 约等于 `512MB`。
> **注意：**
>
> 考虑到 Golang 的内存回收机制以及部分未统计的内存结构，Grafana 中显示的内存与实际的堆内存使用量并不相等。经过实验验证存在约 X0% 的误差。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边测好了么，目前应该大概是 20%?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边测好了么，目前应该大概是 20%?

目前的用的case测出来最高是20%多

@Oreoxmt Oreoxmt requested a review from hfxsd October 27, 2022 06:37
Oreoxmt
Oreoxmt approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 27, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2022
hfxsd
hfxsd reviewed Oct 27, 2022
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
hfxsd
hfxsd approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022
@Oreoxmt @hfxsd
Apply suggestions from code review
b25ddc2 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt Oreoxmt requested a review from qw4990 October 28, 2022 08:36
TomShawn
TomShawn approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn mentioned this pull request Nov 1, 2022
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. for-future-release This PR only applies to master for now and might cherry-pick to a future release. v6.4 This PR/issue applies to TiDB v6.4. and removed translation/doing This PR’s assignee is translating this PR. v6.4 This PR/issue applies to TiDB v6.4. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Nov 1, 2022
hfxsd
hfxsd approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fzzf678
fzzf678 commented Nov 4, 2022
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@TomShawn @fzzf678
Update sql-prepared-plan-cache.md
de4b367 
Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de4b367

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 5f7ad64 into pingcap:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@TomShawn TomShawn TomShawn approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fzzf678 @ti-chi-bot @TomShawn @qw4990 @hfxsd @Oreoxmt