Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add monitor for prepared plan cache memory usage #38507

Merged
merged 34 commits into from Nov 2, 2022
Merged

planner: add monitor for prepared plan cache memory usage #38507

merged 34 commits into from Nov 2, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Oct 17, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #37632

Problem Summary:

What is changed and how it works?

Add metrics to monitor prepared plan cache memory usage and cached plan num from the instance level

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

After add panel:
LyNLxKi6p6

The eighth and ninth panel
planCache-memoryUsage-planNum-panels

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2022
@fzzf678 fzzf678 mentioned this pull request Oct 18, 2022
Closed
25 tasks
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 18, 2022

/run-monitor-test

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
@fzzf678 fzzf678 marked this pull request as ready for review October 24, 2022 08:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2022
@fzzf678 fzzf678 mentioned this pull request Oct 26, 2022
Merged
14 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 27, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@qw4990
Copy link
Contributor

qw4990 commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c661708

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot ti-chi-bot merged commit a3d7420 into pingcap:master Nov 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 2, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 29 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 6 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
release-note-none sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fzzf678 @ti-chi-bot @qw4990 @sre-bot @Reminiscent