Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix statement bug #12255

Merged
merged 2 commits into from Dec 8, 2022
Merged

sql: fix statement bug #12255

merged 2 commits into from Dec 8, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Dec 8, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested a review from Oreoxmt December 8, 2022 09:08
@TomShawn TomShawn requested review from djshow832 and removed request for qiancai December 8, 2022 09:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2022
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. ONCALL Relates to documentation oncall. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2022
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 8, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Dec 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5461f87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@ti-chi-bot ti-chi-bot merged commit 51256f0 into master Dec 8, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12256.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12257.

@TomShawn TomShawn deleted the TomShawn-patch-3 branch December 8, 2022 10:00
ti-chi-bot added a commit that referenced this pull request Dec 8, 2022
ti-chi-bot added a commit that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants