Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix statement bug #11564

Merged
merged 2 commits into from Dec 8, 2022
Merged

sql: fix statement bug #11564

merged 2 commits into from Dec 8, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Dec 8, 2022

What is changed, added or deleted? (Required)

sql: fix statement bug

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from hfxsd December 8, 2022 09:06
@TomShawn TomShawn requested review from Oreoxmt and djshow832 and removed request for hfxsd December 8, 2022 09:06
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Dec 8, 2022
@TomShawn TomShawn self-assigned this Dec 8, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@TomShawn TomShawn added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. translation/doing This PR's assignee is translating this PR. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 8, 2022
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@djshow832
Copy link
Contributor

Why not apply to older versions? I saw that the doc of 5.4 is also wrong.

@TomShawn
Copy link
Contributor Author

TomShawn commented Dec 8, 2022

Why not apply to older versions? I saw that the doc of 5.4 is also wrong.

Because the number of versions is growing very fast, so is the number of branches to cherry-pick. It is not economical to update all applicable versions. So we only update the latest few versions by default (including the latest LTS and DMR) unless someone (from customer feedback) asks for the update of older versions. Then it will be handled on-demand.
image

@TomShawn
Copy link
Contributor Author

TomShawn commented Dec 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 81edc59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@ti-chi-bot ti-chi-bot merged commit 7c3d075 into master Dec 8, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11566.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 8, 2022
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11567.

@TomShawn TomShawn deleted the TomShawn-patch-2 branch December 8, 2022 12:26
ti-chi-bot added a commit that referenced this pull request Dec 8, 2022
ti-chi-bot added a commit that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants