Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev, v2.1, v3.0: remove shared block cache from 2.1 #1624

Merged
merged 3 commits into from
Jul 12, 2019
Merged

dev, v2.1, v3.0: remove shared block cache from 2.1 #1624

merged 3 commits into from
Jul 12, 2019

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 12, 2019 •
edited
Loading

What is changed, added or deleted?

  • Remove the inapplicable shared block cache description from v2.1 (change it back for 2.1)
  • Update description in dev and v3.0

What is the related PR or file link(s)?

#1329

Which version does your change affect?

dev, v3.0, v2.1

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@lilin90 lilin90 requested a review from yikeke July 12, 2019 07:44
yikeke
yikeke approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM

lilin90 and others added 2 commits July 12, 2019 15:53
@lilin90
v2.1: update format
90b4329
@lilin90 @yikeke
Update v2.1/reference/performance/tune-tikv.md
47d71fc 
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@lilin90 lilin90 merged commit 8cd14f9 into pingcap:master Jul 12, 2019
@lilin90 lilin90 deleted the remove-shared-block-cache branch July 12, 2019 08:01
@lilin90 lilin90 mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilin90 @yikeke