Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ticdc: add a warning for the eventually consistent replication feature" #10303

Merged
merged 1 commit into from Sep 1, 2022
Merged

Revert "ticdc: add a warning for the eventually consistent replication feature" #10303

merged 1 commit into from Sep 1, 2022

Conversation

shichun-0415
Copy link
Contributor

Reverts #9544

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Sep 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2022
@shichun-0415 shichun-0415 added require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Sep 1, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01386b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2022
@ti-chi-bot ti-chi-bot merged commit 7cba3b4 into master Sep 1, 2022
@shichun-0415 shichun-0415 deleted the revert-9544-fix-redo-log branch September 1, 2022 08:44
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10304.

This was referenced Sep 1, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10305.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10306.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10307.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10308.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2022
Merged
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
b5f6f99 
…n feature" (#10303) (#10304)
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
3928e2b 
…n feature" (#10303) (#10305)
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
ac39d6c 
…n feature" (#10303) (#10306)
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
3d96f69 
…n feature" (#10303) (#10307)
ti-chi-bot added a commit that referenced this pull request Sep 1, 2022
@ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
0a6e906 
…n feature" (#10303) (#10308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shichun-0415 @ti-chi-bot @TomShawn