Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add a warning for the eventually consistent replication feature #9544

Merged
merged 2 commits into from Jul 12, 2022
Merged

ticdc: add a warning for the eventually consistent replication feature #9544

merged 2 commits into from Jul 12, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 11, 2022
lilin90
lilin90 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 12, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8682ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2022
@ti-chi-bot ti-chi-bot merged commit 482c230 into pingcap:master Jul 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9552.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9553.

@shichun-0415 shichun-0415 deleted the fix-redo-log branch July 12, 2022 13:08
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9554.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9555.

ti-chi-bot added a commit that referenced this pull request Jul 12, 2022
@ti-chi-bot
ticdc: add a warning for the eventually consistent replication feature (
f0f38b0 
#9544) (#9553)
ti-chi-bot added a commit that referenced this pull request Jul 12, 2022
@ti-chi-bot
ticdc: add a warning for the eventually consistent replication feature (
9f8a9bc 
#9544) (#9552)
@shichun-0415 shichun-0415 added the requires-followup This PR requires a follow-up task after being merged. label Jul 12, 2022
ti-chi-bot added a commit that referenced this pull request Jul 12, 2022
@ti-chi-bot
ticdc: add a warning for the eventually consistent replication feature (
a95e1aa 
#9544) (#9554)
ti-chi-bot added a commit that referenced this pull request Jul 12, 2022
@ti-chi-bot
ticdc: add a warning for the eventually consistent replication feature (
33c37cc 
#9544) (#9555)
shichun-0415 added a commit that referenced this pull request Sep 1, 2022
@shichun-0415
Revert "ticdc: add a warning for the eventually consistent replicatio…
01386b3 
…n feature (#9544)"

This reverts commit 482c230.
@shichun-0415 shichun-0415 mentioned this pull request Sep 1, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Sep 1, 2022
@shichun-0415 @ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
2233b06 
…n feature (pingcap#9544)"

This reverts commit 482c230.
This was referenced Sep 1, 2022
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Sep 1, 2022
@shichun-0415 @ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
c78efdc 
…n feature (pingcap#9544)"

This reverts commit 482c230.
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Sep 1, 2022
@shichun-0415 @ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
4803512 
…n feature (pingcap#9544)"

This reverts commit 482c230.
This was referenced Sep 1, 2022
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Sep 1, 2022
@shichun-0415 @ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
5da2bb4 
…n feature (pingcap#9544)"

This reverts commit 482c230.
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Sep 1, 2022
@shichun-0415 @ti-chi-bot
Revert "ticdc: add a warning for the eventually consistent replicatio…
a1c6bac 
…n feature (pingcap#9544)"

This reverts commit 482c230.
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. requires-followup This PR requires a follow-up task after being merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shichun-0415 @ti-chi-bot @lilin90