Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add document for external timestamp read #10783

Merged
merged 6 commits into from Nov 2, 2022
Merged

tidb: add document for external timestamp read #10783

merged 6 commits into from Nov 2, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Oct 11, 2022 •
edited by Oreoxmt

Signed-off-by: YangKeao yangkeao@chunibyo.icu

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a document for external timestamp read and related system variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2022
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from abe76b3 to 597e3bb Compare October 11, 2022 16:46
@Oreoxmt Oreoxmt added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 12, 2022
@Oreoxmt Oreoxmt self-assigned this Oct 12, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for shichun-0415 October 12, 2022 02:10
@Oreoxmt Oreoxmt added the translation/doing This PR's assignee is translating this PR. label Oct 12, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 12, 2022
@Oreoxmt Oreoxmt added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. labels Oct 12, 2022
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 597e3bb to edefcf9 Compare October 12, 2022 04:12
@YangKeao YangKeao mentioned this pull request Oct 12, 2022
Merged
10 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 12, 2022
lcwangchao
lcwangchao reviewed Oct 12, 2022
View reviewed changes
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from edefcf9 to 0958316 Compare October 12, 2022 09:29
Oreoxmt
Oreoxmt reviewed Oct 12, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 0958316 to 184a2b4 Compare October 12, 2022 09:38
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 12, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 184a2b4 to 992f284 Compare October 12, 2022 14:48
@YangKeao
tidb: add document for external timestamp read
ec21941 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 992f284 to ec21941 Compare October 19, 2022 06:01
@Oreoxmt Oreoxmt self-requested a review October 19, 2022 08:09
Oreoxmt
Oreoxmt approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2022
@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch from 6314530 to 0489390 Compare October 19, 2022 08:50
shichun-0415
shichun-0415 reviewed Oct 25, 2022
View reviewed changes
stale-read.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch 2 times, most recently from 4228446 to daf944c Compare October 26, 2022 10:44
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2022
@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch from daf944c to a06261f Compare October 26, 2022 10:46
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2022
@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch from a06261f to 532a611 Compare October 26, 2022 10:47
@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch from 6488a62 to 080ab4c Compare October 26, 2022 10:55
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 1, 2022

DNM until pingcap/tidb#38276 is merged

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2022
Oreoxmt
Oreoxmt approved these changes Nov 2, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b81c687

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot ti-chi-bot merged commit 43c93f0 into pingcap:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YangKeao @ti-chi-bot @CLAassistant @Oreoxmt @lcwangchao @shichun-0415