Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add variables and support external timestamp read #38276

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 30, 2022

What problem does this PR solve?

Issue Number: close #38274

Problem Summary:

TiDB doesn't have a way to allow staleread with a timestamp from external (globally).

What is changed and how it works?

  1. Add two variables to control the timestamp (tidb_external_ts) and whether to enable this feature (tidb_enable_external_ts_read)
  2. If there is no explicitly stale-read (e.g. select as of, start transaction as of, set tidb_read_staleness...), and the control variable is on, use the external timestamp to perform stale read.

TODO:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add two system variables `tidb_external_ts` and `tidb_enable_external_ts_read`. If the `tidb_enable_external_ts_read` is on, the tidb will be in read-only mode and read through the timestamp set in `tidb_external_ts`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao YangKeao requested a review from a team as a code owner September 30, 2022 07:34
@ti-chi-bot ti-chi-bot added release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2022
@YangKeao YangKeao marked this pull request as draft September 30, 2022 07:34
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2022
@YangKeao YangKeao changed the title *: support external timestamp read for staleread *: add variables and support external timestamp read Sep 30, 2022
@YangKeao YangKeao force-pushed the external-timestamp-read branch 4 times, most recently from f7a8bc5 to 5e95ec2 Compare September 30, 2022 08:27
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022
@@ -1478,7 +1488,7 @@ func (connInfo *ConnectionInfo) IsSecureTransport() bool {
}

// NewSessionVars creates a session vars object.
func NewSessionVars() *SessionVars {
func NewSessionVars(hctx HookContext) *SessionVars {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it necessary to change the definition of NewSessionVars, which introduced so many changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, these changes have been merged into master in #38227. @morgo Provided a better way to work around this 👍 . I'll revert these changes after #38182 merged 😃

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 8, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2022
@YangKeao YangKeao force-pushed the external-timestamp-read branch 4 times, most recently from 81d76b6 to b8a1718 Compare October 12, 2022 09:24
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2022
@YangKeao YangKeao force-pushed the external-timestamp-read branch 2 times, most recently from b737ea8 to dabf247 Compare November 1, 2022 03:11
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2022
expression/builtin_time.go Outdated Show resolved Hide resolved
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 1, 2022
@YangKeao YangKeao force-pushed the external-timestamp-read branch 2 times, most recently from db7b3ec to 445d678 Compare November 1, 2022 05:46
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2022
planner/core/planbuilder.go Outdated Show resolved Hide resolved
sessionctx/variable/sysvar.go Show resolved Hide resolved
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Copy link
Collaborator

@lcwangchao lcwangchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2022
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 24ba369

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2022
@ti-chi-bot ti-chi-bot merged commit ba6ae45 into pingcap:master Nov 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 28 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 33 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support external timestamp read
7 participants