Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ticdc #11570

Merged
merged 15 commits into from Dec 13, 2022
Merged

Refactor ticdc #11570

merged 15 commits into from Dec 13, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Dec 9, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Align with all docs in pingcap/docs-cn#11849, except for the following two docs:

  • ticdc-architecture.md
  • ticdc-overview

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2022
@shichun-0415 shichun-0415 added type/refactor Reorganizes the documentation structure. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed missing-translation-status This PR does not have translation status info. labels Dec 9, 2022
@IANTHEREAL
Copy link
Contributor

Rest LGTM

shichun-0415
shichun-0415 commented Dec 12, 2022
View reviewed changes
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
releases/release-6.3.0.md Outdated Show resolved Hide resolved
nongfushanquan
nongfushanquan reviewed Dec 12, 2022
View reviewed changes
ticdc/ticdc-manage-changefeed.md
>
> For tables without a valid index, operations such as `INSERT` and `REPLACE` are not reentrant, so there is a risk of data redundancy. TiCDC guarantees that data is distributed only at least once during the replication process. Therefore, enabling this feature to replicate tables without a valid index will definitely cause data redundancy. If you do not accept data redundancy, it is recommended to add an effective index, such as adding a primary key column with the `AUTO RANDOM` attribute.

## Unified Sorter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this part "unified sorter"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR to address this comment.

@shichun-0415 shichun-0415 mentioned this pull request Dec 12, 2022
Merged
15 tasks
qiancai
qiancai reviewed Dec 12, 2022
View reviewed changes
ticdc/deploy-ticdc.md Outdated Show resolved Hide resolved
ticdc/deploy-ticdc.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-mysql.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-mysql.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-mysql.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-mysql.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
@shichun-0415 @qiancai
Apply suggestions from code review
7068d2e 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415 shichun-0415 removed the request for review from TomShawn December 12, 2022 10:17
qiancai
qiancai approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2022
@shichun-0415 @qiancai
Update ticdc/ticdc-sink-to-mysql.md
158fb49 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415
Copy link
Contributor Author

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 13, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 158fb49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2022
@ti-chi-bot ti-chi-bot merged commit d654c62 into pingcap:master Dec 13, 2022
@shichun-0415 shichun-0415 deleted the refactor-ticdc branch December 13, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/refactor Reorganizes the documentation structure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shichun-0415 @ti-chi-bot @IANTHEREAL @qiancai @nongfushanquan