reference/mysql-compatibility: Version comments #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f3c3ac4.
Add as a potential source of incompatibility
morgo
added
the
requires-version-specific-changes
|
This applies to all versions, the PR needs to be updated. |
morgo
removed
the
requires-version-specific-changes
|
@kolbe PTAL again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (required)
The way TiDB parses and executes version-comments can potentially break apps. See pingcap/tidb#10804 for example.
What is the related PR or file link(s)? (required)
Relates to pingcap/tidb#10804 (but another fix will be used for this bug)
Which version does your change affect? (required)
It applies to all versions.
Did you use Tab spaces in this PR? (required)
No