Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add newly added lightning kv configurations #13004

Merged
merged 7 commits into from Mar 28, 2023
Merged

dm: add newly added lightning kv configurations #13004

merged 7 commits into from Mar 28, 2023

Conversation

lichunzhu
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

pingcap/tiflow#8654 add configurations for newly added lightning kv configurations

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
@lichunzhu lichunzhu changed the title fix configure dm: add newly added lightning kv configurations Mar 23, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2023
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. for-cloud-release This PR is related to TiDB Cloud release. v7.0 labels Mar 23, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 23, 2023
ran-huang
ran-huang reviewed Mar 24, 2023
View reviewed changes
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
@lichunzhu @ran-huang
Apply suggestions from code review
d88c97a 
Co-authored-by: Ran <huangran@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2023
@ran-huang ran-huang added require-LGT1 Indicates that the PR requires an LGTM. and removed for-cloud-release This PR is related to TiDB Cloud release. labels Mar 28, 2023
@ran-huang ran-huang added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Mar 28, 2023
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ef3859

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@ti-chi-bot ti-chi-bot merged commit f200376 into master Mar 28, 2023
5 of 6 checks passed
@lilin90 lilin90 deleted the fixLightningConfig branch August 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

Assignees

@lichunzhu lichunzhu

Labels
area/dm for-release This PR relates to a TiDB release but does not have a tracked feature. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lichunzhu @ti-chi-bot @ran-huang @Oreoxmt