Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: fix lightning config problem #8653

Merged
merged 8 commits into from
Mar 23, 2023
Merged

dm: fix lightning config problem #8653

merged 8 commits into from
Mar 23, 2023

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Mar 22, 2023 •
edited

What problem does this PR solve?

Issue Number: close #8654

What is changed and how it works?

  1. Fix sort-kv-dir not correctly set problem.
  2. Add some configurations for lightning.

Check List

Tests

  • Unit test
  • Manual test
    used in dm physical mode performance test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2023
@lichunzhu
Copy link
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.0 Should cherry pick this PR to release-7.0 branch. and removed do-not-merge/needs-triage-completed labels Mar 22, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2023
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-engine-integration-test

@lance6716
Copy link
Contributor

Don't forget to ask PM for better configuration names

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Mar 23, 2023
@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2023
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 23, 2023
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu mentioned this pull request Mar 23, 2023
Merged
16 tasks
@lichunzhu
Copy link
Contributor Author

/verify-ci

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu mentioned this pull request Mar 23, 2023
Merged
16 tasks
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6772b33

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@lichunzhu
Copy link
Contributor Author

/run-verify-ci

@lichunzhu
Copy link
Contributor Author

/run-engine-integration-test

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot merged commit 4a196c5 into pingcap:master Mar 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #8658.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 23, 2023
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#8653
0d48c27 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #8659.

ti-chi-bot added a commit that referenced this pull request Mar 23, 2023
@ti-chi-bot
dm: fix lightning config problem (#8653) (#8659)
fd2efea 
close #8654
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Apr 3, 2023
@lichunzhu @3AceShowHand
dm: fix lightning config problem (pingcap#8653)
09b051d 
close pingcap#8654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@sleepymole sleepymole sleepymole approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. needs-cherry-pick-release-7.0 Should cherry pick this PR to release-7.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM: loader physical mode cannot set sorted kv dir correctly
5 participants
@lichunzhu @ti-chi-bot @lance6716 @D3Hunter @sleepymole