Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb.*cf: supply descriptions on ttl and periodic-compaction-seconds. #13980

Merged
merged 3 commits into from Jun 28, 2023
Merged

rocksdb.*cf: supply descriptions on ttl and periodic-compaction-seconds. #13980

merged 3 commits into from Jun 28, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jun 26, 2023 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@LykxSassinator
rocksdb.*cf: supply descriptions on ttl and `periodic-compaction-se…
a66fe6f 
…conds`

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2023
@LykxSassinator LykxSassinator mentioned this pull request Jun 26, 2023
Merged
17 tasks
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. for-release This PR relates to a TiDB release but does not have a tracked feature. v7.2 labels Jun 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 26, 2023
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed translation/doing This PR's assignee is translating this PR. labels Jun 26, 2023
@qiancai qiancai self-requested a review June 27, 2023 16:25
@qiancai qiancai self-assigned this Jun 27, 2023
qiancai
qiancai reviewed Jun 27, 2023
View reviewed changes
tikv-configuration-file.md Show resolved Hide resolved
tikv-configuration-file.md Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
LykxSassinator
LykxSassinator commented Jun 28, 2023
View reviewed changes
Copy link
Contributor Author

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt self-requested a review June 28, 2023 08:38
Oreoxmt
Oreoxmt approved these changes Jun 28, 2023
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@qiancai @Oreoxmt
format updates
85240f5 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 09:04:11.087912987 +0000 UTC m=+784816.489163436: ☑️ agreed by Oreoxmt.
  • 2023-06-28 09:07:35.065041089 +0000 UTC m=+785020.466291523: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Jun 28, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2321db7 into pingcap:master Jun 28, 2023
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14033.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 28, 2023
@ti-chi-bot
rocksdb.*cf: supply descriptions on ttl and `periodic-compaction-se…
043ba73 
…conds`. (#13980) (#14033)
This was referenced Oct 7, 2023
Merged
Merged
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 18, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15130.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 18, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15131.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 18, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@ti-chi-bot
Do not merge until v7.1.2: rocksdb.*cf: supply descriptions on ttl …
3b26a50 
…and `periodic-compaction-seconds`. (#13980) (#15130)
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ti-chi-bot
v6.5.4 rocksdb.*cf: supply descriptions on ttl and `periodic-compac…
441eadd 
…tion-seconds`. (#13980) (#15131)
This was referenced Oct 30, 2023
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ti-chi-bot
v6.5.4 rocksdb.*cf: supply descriptions on ttl and `periodic-compac…
6c78052 
…tion-seconds`. (#13980) (#15131) (#15201)
This was referenced Oct 30, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ti-chi-bot
v6.5.4 rocksdb.*cf: supply descriptions on ttl and `periodic-compac…
5f3f32f 
…tion-seconds`. (#13980) (#15131) (#15201) (#15202)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ti-chi-bot
v6.5.4 rocksdb.*cf: supply descriptions on ttl and `periodic-compac…
6469e77 
…tion-seconds`. (#13980) (#15131) (#15201) (#15205)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ti-chi-bot
v6.5.4 rocksdb.*cf: supply descriptions on ttl and `periodic-compac…
cd0a6ae 
…tion-seconds`. (#13980) (#15131) (#15201) (#15203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LykxSassinator @qiancai @ti-chi-bot @overvenus @Oreoxmt