Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.5.4 rocksdb.*cf: supply descriptions on ttl and periodic-compaction-seconds. (#13980) #15131

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 18, 2023

This is an automated cherry-pick of #13980

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

LykxSassinator and others added 3 commits October 18, 2023 07:13
…conds`

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. v7.2 labels Oct 18, 2023
@qiancai qiancai changed the title rocksdb.*cf: supply descriptions on ttl and periodic-compaction-seconds. (#13980) v6.5.4 rocksdb.*cf: supply descriptions on ttl and periodic-compaction-seconds. (#13980) Oct 18, 2023
@qiancai qiancai added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Oct 18, 2023
releases/release-6.5.4.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
Co-authored-by: glorv <glorvs@163.com>
@@ -1496,6 +1496,18 @@ Configuration items related to `rocksdb.defaultcf`, `rocksdb.writecf`, and `rock
- `5`: Can be read by TiKV v6.1 and later versions. Full and partitioned filters use a faster and more accurate Bloom filter implementation with a different schema.
+ Default value: `2`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文档,cp 后修改了 L1499, L1502, L1505, L1508

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文档,cp 后新增了 L17

Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Ran <huangran.alex@gmail.com>
@qiancai
Copy link
Collaborator

qiancai commented Oct 18, 2023

/cc @ran-huang

@ti-chi-bot ti-chi-bot bot requested a review from ran-huang October 18, 2023 08:35
@qiancai qiancai added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Oct 30, 2023
@qiancai
Copy link
Collaborator

qiancai commented Oct 30, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 441eadd into pingcap:release-6.5 Oct 30, 2023
9 checks passed
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch master: #15201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. v7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants