-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.5.4 rocksdb.*cf: supply descriptions on ttl
and periodic-compaction-seconds
. (#13980)
#15131
v6.5.4 rocksdb.*cf: supply descriptions on ttl
and periodic-compaction-seconds
. (#13980)
#15131
Conversation
…conds` Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
ttl
and periodic-compaction-seconds
. (#13980)ttl
and periodic-compaction-seconds
. (#13980)
Co-authored-by: glorv <glorvs@163.com>
@@ -1496,6 +1496,18 @@ Configuration items related to `rocksdb.defaultcf`, `rocksdb.writecf`, and `rock | |||
- `5`: Can be read by TiKV v6.1 and later versions. Full and partitioned filters use a faster and more accurate Bloom filter implementation with a different schema. | |||
+ Default value: `2` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文档,cp 后修改了 L1499, L1502, L1505, L1508
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文档,cp 后新增了 L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Ran <huangran.alex@gmail.com>
/cc @ran-huang |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
This is an automated cherry-pick of #13980
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?