tidb-in-kubernetes: add local pv example #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherrachel
added
area/tidb-in-k8s-v1.0
dev
translation/from-docs-cn
anotherrachel
force-pushed
the
add-local-pv-example-new
branch
from
3e78593
to
afd3d72
Compare
|
@DanielZhangQD @yikeke PTAL, thanks! |
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
|
@anotherrachel Please address comments. |
added 2 commits
November 6, 2019 15:17
|
@DanielZhangQD All comments addressed. PTAL again, thanks! |
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
yikeke
reviewed
Nov 8, 2019
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
|
@yikeke @DanielZhangQD PTAL again~ |
yikeke
reviewed
Nov 11, 2019
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
yikeke
suggested changes
Nov 14, 2019
There was a problem hiding this comment.
Please apply the changes in pingcap/docs-cn#2035 to this PR~ @anotherrachel
Aligning |
|
@yikeke @DanielZhangQD Changes in #2035 have been applied. PTAL again, thanks! |
|
@yikeke PTAL again~ |
|
@anotherrachel Please also help apply changes to |
yikeke
reviewed
Nov 20, 2019
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
dev/tidb-in-kubernetes/reference/configuration/storage-class.md
Outdated
Show resolved
Hide resolved
|
@yikeke All comments addressed. If the content is ready, I'll update other versions soon. PTAL again, thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
This PR adds an example about how to mount disks, modify and create local-volume-provisioner accordingly to use local disks for monitor, backup, binlog, pd and tikv, etc.
What is the related PR or file link(s)?
pingcap/docs-cn#1808
pingcap/docs-cn#2035
Which version does your change affect?
dev, v3.0, v3.1