Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-in-kubernetes: add local pv example #1808

Merged
merged 7 commits into from
Sep 4, 2019

Conversation

DanielZhangQD
Copy link
Contributor

What is changed, added or deleted?

Add an example about how to mount disks, modify and create local-volume-provisioner accordingly to use local disks for monitor, backup, binlog, pd and tikv, etc.

What is the related PR or file link(s)?

Which version does your change affect?

dev, v3.0

DanielZhangQD and others added 3 commits August 30, 2019 19:56
Co-Authored-By: Calvin Weng <wenghao@pingcap.com>
Co-Authored-By: Calvin Weng <wenghao@pingcap.com>
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor Author

@dcalvin comments addressed, PTAL again.

Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 396dc22 into pingcap:master Sep 4, 2019
@DanielZhangQD DanielZhangQD deleted the local branch September 4, 2019 07:37
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Sep 5, 2019
@yikeke yikeke assigned anotherrachel and unassigned yikeke Sep 24, 2019
@anotherrachel anotherrachel added aligning and removed translation/doing This PR’s assignee is translating this PR. labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants