-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc: fix some typos in the open protocol #4130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/label needs-cherry-pick-4.0, size/small, translation/from-docs-cn |
ti-srebot
added
needs-cherry-pick-4.0
size/small
Changes of a small size.
translation/from-docs-cn
This PR is translated from a PR in pingcap/docs-cn.
labels
Nov 2, 2020
/cc TomShawn |
kennytm
reviewed
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomShawn
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
cherry pick to release-4.0 in PR #4131 |
ti-srebot
added a commit
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/small
Changes of a small size.
status/LGT1
Indicates that a PR has LGTM 1.
translation/from-docs-cn
This PR is translated from a PR in pingcap/docs-cn.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some typos in the CDC open protocol.
TINTTEXT → TINYTEXT
Too little backslashes in the VARBINARY/BINARY examples, there should be two backslashes in the rendered JSON, and thus four backslashes in markdown.
\x80...\xFF are not ASCII, just don't mention ASCII.
BinaryFlag is used for VARBINARY/BINARY too, don't just mention the BLOB family.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?