Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: fix some typos in the open protocol #4130

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Nov 2, 2020

Fixed some typos in the CDC open protocol.

TINTTEXT → TINYTEXT
Too little backslashes in the VARBINARY/BINARY examples, there should be two backslashes in the rendered JSON, and thus four backslashes in markdown.
\x80...\xFF are not ASCII, just don't mention ASCII.
BinaryFlag is used for VARBINARY/BINARY too, don't just mention the BLOB family.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Nov 2, 2020

/label needs-cherry-pick-4.0, size/small, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 2, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Nov 2, 2020

/cc TomShawn

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@kennytm, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@TomShawn TomShawn merged commit cbc7ff1 into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4131

ti-srebot added a commit that referenced this pull request Nov 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants