New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add documents for cost model variables #9802
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/verify |
@qw4990 PTAL |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
93373a6
to
70892d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
/remove-status LGT1 |
This pull request has been accepted and is ready to merge. Commit hash: d081be1
|
In response to a cherrypick label: new pull request created: #10669. |
* add cost model * fix typo * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * update the cost model * Apply suggestions from code review * Apply suggestions from code review * translate from pingcap/docs-cn#10760 * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * apply suggestions from @qw4990 * Update system-variables.md * Apply suggestions from code review * Update sql-physical-optimization.md Co-authored-by: Aolin <aolin.zhang@pingcap.com> Co-authored-by: Aolin <aolinz@outlook.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?