Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add documents for cost model variables #9802

Merged
merged 9 commits into from Aug 5, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Aug 3, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Add a document to introduce cost model in TiDB.
  • Add two system variables tidb_cost_model_version and tidb_enable_new_cost_interface.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2. labels Aug 3, 2022
@Oreoxmt Oreoxmt requested review from qw4990 and TomShawn August 3, 2022 03:58
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Oreoxmt Oreoxmt self-assigned this Aug 3, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 3, 2022

/verify

cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from TomShawn August 4, 2022 06:03
@Oreoxmt Oreoxmt added the status/PTAL This PR is ready for reviewing. label Aug 4, 2022
cost-model.md Outdated Show resolved Hide resolved
cost-model.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 5, 2022

@qw4990 PTAL

cost-model.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2022
Oreoxmt and others added 2 commits August 5, 2022 15:16
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Oreoxmt Oreoxmt removed the status/PTAL This PR is ready for reviewing. label Aug 5, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 5, 2022

/remove-status LGT1
/status LGT2
/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d081be1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 5e05281 into pingcap:master Aug 5, 2022
@Oreoxmt Oreoxmt deleted the translate/docs-cn-10609 branch September 20, 2022 06:42
@TomShawn TomShawn added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 9, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10669.

TomShawn added a commit that referenced this pull request Oct 9, 2022
* add cost model

* fix typo

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* update the cost model

* Apply suggestions from code review

* Apply suggestions from code review

* translate from pingcap/docs-cn#10760

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* apply suggestions from @qw4990

* Update system-variables.md

* Apply suggestions from code review

* Update sql-physical-optimization.md

Co-authored-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants