[6.1] Cherry-pick changes about the fix of pessimistic transactions with primary changed #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith primary changed * Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (pingcap#1105) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: ekexium <eke@fastmail.com>
ekexium
approved these changes
Jun 29, 2023
cfzjywxk
approved these changes
Jun 29, 2023
|
Sorry. I noticed that some released versions with larger minor version number than 6.1 (like 6.5) doesn't contain this fix. Fixing this in 6.1 branch might cause problem if there are any user trying to upgrade to older version in newer branch (such as upgrading from 6.1.7 to 6.5.0). For this reason, whether this bug should be fixed in 6.1 branch needs discussion. |
|
Got it,I think to keep compatibility we could skip the fix on v6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: pingcap/tidb#42937
Cherry-picks #1105 #1107 to release-6.5 branch