Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdpb: revert "pdpb: include down/pending peers in scan region response (#646)" #659

Closed
wants to merge 1 commit into from

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Aug 3, 2020

This reverts #646 since it breaks backwards compatibility and prevents updating TiDB:

➜  tidb git:(master) ✗ make
CGO_ENABLED=1 GO111MODULE=on go build  -tags codes  -ldflags '-X "github.com/pingcap/parser/mysql.TiDBReleaseVersion=v4.0.0-beta.2-872-g03003538d-dirty" -X "github.com/pingcap/tidb/util/versioninfo.TiDBBuildTS=2020-08-03 03:25:04" -X "github.com/pingcap/tidb/util/versioninfo.TiDBGitHash=03003538d1d7a1762e02fc62365e4832f9df4dd7" -X "github.com/pingcap/tidb/util/versioninfo.TiDBGitBranch=master" -X "github.com/pingcap/tidb/util/versioninfo.TiDBEdition=Community" ' -o bin/tidb-server tidb-server/main.go
# github.com/pingcap/pd/v4/client
../../gopath/pkg/mod/github.com/pingcap/pd/v4@v4.0.0-rc.2.0.20200714122454-1a64f969cb3c/client/client.go:562:24: cannot use resp.GetRegions() (type []*pdpb.Region) as type []*metapb.Region in return argument
make: *** [server] Error 2

PTAL @disksing @rleungx

pingcap#646)"

This reverts commit c3e2e0b.

Signed-off-by: Nick Cameron <nrc@ncameron.org>
@disksing
Copy link
Contributor

disksing commented Aug 3, 2020

It seems we should be able to upgrade by migrating some function calls to the new interface. Let me take a look.

@nrc
Copy link
Contributor Author

nrc commented Aug 3, 2020

The TiDB build issue is addressed in pingcap/tidb#18938, aiui, the back compat issue will not be a problem at runtime because of the region_metas field and kvproto is not a published crate, so I think we can close this for now.

@nrc nrc closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants