Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mysql-tester, enhance some implementations #109

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Improve mysql-tester, enhance some implementations #109

merged 8 commits into from
Nov 9, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 8, 2023 •
edited
Loading

  1. Remove dependence on tidb/parser, avoid parser error caused by untimely updates.
  2. Support tidb_multi_statement_mode and enable it by default.
  3. Remove internal txn to support optimistic txn.
  4. Remove singleQuery related codes.
  5. Remove IsQuery check, print execute result regardless what type of SQL is.

@Defined2014 Defined2014 changed the title Improve mysql-tester, enhance some functions Improve mysql-tester, enhance some features Nov 8, 2023
@Defined2014 Defined2014 changed the title Improve mysql-tester, enhance some features Improve mysql-tester, enhance some implementions Nov 8, 2023
@Defined2014 Defined2014 changed the title Improve mysql-tester, enhance some implementions Improve mysql-tester, enhance some implementations Nov 8, 2023
@Defined2014
Copy link
Contributor Author

/cc @bb7133 @tiancaiamao
PTAL

tiancaiamao
tiancaiamao approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we import parser in the past, but it is fair to say I'd rather go without it.

bb7133
bb7133 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit fe93e79 into pingcap:master Nov 9, 2023
1 check passed
This was referenced Nov 9, 2023
Merged
Open
@YangKeao YangKeao mentioned this pull request Feb 18, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Defined2014 @bb7133 @tiancaiamao