Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support hints in 'REPLACE INTO' statement (#50007) #50676

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50007

What problem does this PR solve?

Issue Number: close #34325

Problem Summary:

Hints are not supported in REPLACE INTO ... statement.

What changed and how does it work?

I simply modify the parser to support this hints. I also tested that some simple hints (e.g. SET_VAR) actually work.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that hints are not supported in the `REPLACE INTO` statement.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 6, 2024
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-27 15:20:46.537178612 +0000 UTC m=+1233288.101476315: ☑️ agreed by AilinKid.
  • 2024-02-18 08:34:48.995866675 +0000 UTC m=+173377.743489787: ☑️ agreed by YangKeao.

@easonn7
Copy link

easonn7 commented Feb 18, 2024

/approve

@YangKeao YangKeao force-pushed the cherry-pick-50007-to-release-7.5 branch 2 times, most recently from 00c96a4 to 3143d1a Compare February 18, 2024 09:19
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member

/retest

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@8aa2293). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50676   +/-   ##
================================================
  Coverage               ?   72.2541%           
================================================
  Files                  ?       1403           
  Lines                  ?     409023           
  Branches               ?          0           
================================================
  Hits                   ?     295536           
  Misses                 ?      93846           
  Partials               ?      19641           
Flag Coverage Δ
unit 72.2541% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3191% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 18, 2024
@YangKeao
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit a7114f3 into pingcap:release-7.5 Feb 18, 2024
17 of 18 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants