parser: support the 'create global temporary table' syntax #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djshow832
reviewed
Apr 21, 2021
89 tasks
|
Integration test is fixed in pingcap/tidb#24196 |
|
I've change |
djshow832
reviewed
Apr 27, 2021
|
/lgtm |
coocood
reviewed
Apr 27, 2021
|
/lgtm |
ti-srebot
previously approved these changes
Apr 27, 2021
|
/merge |
|
/run-all-tests |
|
@tiancaiamao merge failed. |
tiancaiamao
force-pushed
the
temporary-table
branch
from
8ab637c
to
1580f71
Compare
|
/check-cla |
tiancaiamao
force-pushed
the
temporary-table
branch
from
100a436
to
16a0f9d
Compare
|
The license/cal check fails and I try to modify the git history of my commit email, PTAL @coocood @djshow832 |
|
/lgtm |
coocood
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support
create global temporary table ... on commit delete rowsSee pingcap/tidb#24168
What is changed and how it works?
This syntax is compatible with MySQL temporary table, a
GLOBALkeyword is used to distinguish them.This syntax is much the same with Oracle (and also the ANSI SQL standard).
A compatibility issue is that when a user use this syntax and use a downstream MySQL as TiDB backup, they will encounter DDL error when the use this statement, because this syntax is a superset of the MySQL syntax.
In the real use cases, it shouldn't be a problem, because if a user use this syntax, they probably migrating from Oracle, so they do not use a MySQL backup.
Check List
Tests
Code changes
Related changes