parser: add AsOfClause for START TRANSACTION READ ONLY statement #1215
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
|
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
as_of_beginsmt
branch
from
33442f1
to
2dcbd7c
Compare
#1211 introduced a change to TiDB that is not forward compatible. I'm waiting for the merging of pingcap/tidb#24196, then I will resolve the conflict. |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
ast/functions.go
Outdated
| // TiDBBoundStaleness is used to determine the TS for a read only request. | ||
| // It will be used in the Stale Read feature. | ||
| // For more info, please see AsOfClause. | ||
| TiDBBoundStaleness = "tidb_bound_staleness" |
There was a problem hiding this comment.
It should be bounded staleness rather than bound staleness.
There was a problem hiding this comment.
I think it's ok to use the passive voice bound here as an adjective, and it's shorter than bounded.
There was a problem hiding this comment.
If you google bound staleness, the results are all bounded staleness.
There was a problem hiding this comment.
Fair enough. So what about tidb_bounded_staleness or tidb_staleness_bound?
There was a problem hiding this comment.
There was a problem hiding this comment.
I rename it to tidb_staleness_bound, PTAL!
There was a problem hiding this comment.
@morgo PTAL, what do you think?
There was a problem hiding this comment.
I prefer tidb_bounded_staleness . :)
There was a problem hiding this comment.
Yeah, I agree with @nolouch :-)
There was a problem hiding this comment.
@morgo @nolouch @djshow832 I finished the renaming, PTAL.
Co-authored-by: djshow832 <zhangming@pingcap.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
/lgtm |
|
/lgtm |
|
/merge |
|
/run-all-tests |
|
@JmPotato merge failed. |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-srebot
added
status/LGT3
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Part of pingcap/tidb#24291. Add
AsOfClauseforSTART TRANSACTION READ ONLYstatement.What is changed and how it works?
START TRANSACTION READ ONLYstatement.TIDB_BOUNDED_STALENESSbuilt-in function.Check List
Tests
Related changes: #1206