Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Fix tidb issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* #1224

Merged
merged 3 commits into from
May 13, 2021
Merged

parser: Fix tidb issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* #1224

merged 3 commits into from
May 13, 2021

Conversation

sylzd
Copy link
Contributor

@sylzd sylzd commented May 11, 2021 •
edited

What problem does this PR solve?

Fix mysql grant action compatibility
related to pingcap/tidb#24439
related to pingcap/tidb#24485

What is changed and how it works?

Add  StaticGlobalOnlyPrivs in privs.go

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@CLAassistant
Copy link

CLAassistant commented May 11, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@sylzd sylzd changed the title *: Fix tidb issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* parser: Fix tidb issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* May 11, 2021
@sylzd sylzd mentioned this pull request May 11, 2021
Merged
@sylzd
Copy link
Contributor Author

sylzd commented May 11, 2021

I don't know why my tests failed with a variable added.

@sylzd
Copy link
Contributor Author

sylzd commented May 11, 2021

@morgo PTAL

@morgo
Copy link
Contributor

morgo commented May 12, 2021

/LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label May 12, 2021
@sylzd
Copy link
Contributor Author

sylzd commented May 12, 2021

@wshwsh12 PTAL related to pingcap/tidb#24485

@wshwsh12
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label May 12, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label May 12, 2021
@morgo morgo merged commit ae2c449 into pingcap:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sylzd @CLAassistant @morgo @wshwsh12 @ti-srebot