Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add flush tidb plugins [plugin-name,..] support #209

Merged
merged 3 commits into from
Feb 18, 2019
Merged

plugin: add flush tidb plugins [plugin-name,..] support #209

merged 3 commits into from
Feb 18, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Feb 14, 2019

What problem does this PR solve?

refer pingcap/tidb#9136

For reasons of efficiency, plugin often caches some metadata / config in each tidb nodes, and we need a mechanism to update plugin related metadata / config for each of them.

What is changed and how it works?

After discuss with @tennix @tiancaiamao @jackysp,

we decide to use "mutator notify plugin data changed and plugin pull new configuration pattern".

  • make plugin be flushable
  • mutator will call flush tidb plugins ${plugin-name,..} in one of tidb-servers
  • plugin framework notify all plugin in every tidb-server node via etcd
  • plugin pull new configuration into cache.

so, this PR address (1) to add flush tidb plugins [name,...] in parser, old flush status has some special means in mysql, so we choosen new one.

Check List

Tests

  • Unit test

Code changes

  • New tidb keyword

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@tiancaiamao
Copy link
Collaborator

How about flush tidb plugin [plugin-name], as we already have the tidb keywords?

@lysu lysu changed the title plugin: add flush tidb_plugin [plugin-name] support plugin: add flush tidb plugins [plugin-name,..] support Feb 15, 2019
@tiancaiamao
Copy link
Collaborator

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit 9545f16 into pingcap:master Feb 18, 2019
@lysu lysu deleted the dev-flush-stats branch February 18, 2019 03:35
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants