Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: support flush tidb plugin {name} in tidb-server #9320

Merged
merged 1 commit into from Feb 18, 2019
Merged

plugin: support flush tidb plugin {name} in tidb-server #9320

merged 1 commit into from Feb 18, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Feb 15, 2019

What problem does this PR solve?

refer pingcap/parser#209 and prepose to #9136

What is changed and how it works?

impl was insprited by #9271

  • make plugin can choosen be flushable
  • support flush tidb plugin {name} command
  • plugin framework help plugins watch etcd and support notify other tidb nodes about flush event
  • temp remove reload logic which is too complex but use limited for current stage.

use 2 phase init, plugin can Init before domain init and start watch loops after domain be ready.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

script: (WIP)

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu
Copy link
Collaborator Author

lysu commented Feb 15, 2019

/run-all-tests

1 similar comment
@lysu
Copy link
Collaborator Author

lysu commented Feb 15, 2019

/run-all-tests

@lysu lysu requested a review from jackysp February 15, 2019 11:06
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2019
@lysu
Copy link
Collaborator Author

lysu commented Feb 18, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit 84d1513 into pingcap:master Feb 18, 2019
@lysu lysu deleted the dev-support-flush-plugin branch February 18, 2019 05:48
@codecov-io
Copy link

Codecov Report

Merging #9320 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9320      +/-   ##
=========================================
- Coverage    67.2%   67.2%   -0.01%     
=========================================
  Files         371     371              
  Lines       77572   77574       +2     
=========================================
+ Hits        52132   52133       +1     
  Misses      20783   20783              
- Partials     4657    4658       +1
Impacted Files Coverage Δ
plugin/spi.go 100% <ø> (ø) ⬆️
session/session.go 72.48% <0%> (-0.16%) ⬇️
plugin/plugin.go 0% <0%> (ø) ⬆️
executor/simple.go 67.51% <0%> (+1.12%) ⬆️
executor/join.go 77.86% <0%> (-0.53%) ⬇️
executor/executor.go 67.03% <0%> (+0.13%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e78ebc...3fbcf70. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants