terror: expose args from Error #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
ghost
requested review from
|
|
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=========================================
- Coverage 77.61% 77.6% -0.02%
=========================================
Files 40 40
Lines 14294 14296 +2
=========================================
Hits 11095 11095
- Misses 2528 2530 +2
Partials 671 671 |
zimulala
reviewed
Feb 5, 2020
| @@ -177,6 +177,11 @@ func (e *Error) Code() ErrCode { | |||
| return e.code | |||
| } | |||
|
|
|||
| // Args returns the inner args | |||
There was a problem hiding this comment.
Suggested change
| // Args returns the inner args | |
| // Args returns the inner args. |
|
Closed as pingcap/tidb#14626 is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Required by pingcap/tidb#14626, the
argsofErrorneed be exposed.What is changed and how it works?
Add a method to
Errorthat returns theargs.Check List
Tests
Code changes